[PATCH] D149072: [CMake] Serialize `build_native_tool`

Chris Bieneman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 27 08:18:58 PDT 2023


beanz added a comment.

This will regress build times for Makefile and Ninja builds, particularly clean builds (which is what GitHub Actions, Azure Pipelines, and Google Cloud Pipelines all do).

Please restrict the change to only impact Visual Studio which I think is the only generator that can be impacted by the race condition. Xcode may be sub-optimal with the current behavior but probably isn't impacted by the race because the filesystem locking behavior is likely NTFS-specific.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149072/new/

https://reviews.llvm.org/D149072



More information about the llvm-commits mailing list