[PATCH] D149348: RFD: Do not CSE convergent calls in different basic blocks

[Nikita Popov via Phabricator via llvm-commits]

nikic requested changes to this revision.
nikic added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/lib/IR/Instruction.cpp:529
+    if (CI->isConvergent() && CI->getParent() != I2->getParent())
+      return false;
+    return true;
----------------
This check should not be part of hasSameSpecialState(). It's not the job of this function to model any dependencies, be they memory dependencies or convergence.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149348/new/

https://reviews.llvm.org/D149348