[PATCH] D129370: [SimplifyCFG] Allow SimplifyCFG hoisting to skip over non-matching instructions

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.
Herald added subscribers: hoy, StephenFan.


================
Comment at: llvm/lib/Transforms/Utils/SimplifyCFG.cpp:1584
+        if (C1->isMustTailCall() != C2->isMustTailCall())
+          return Changed;
+
----------------
Leaving these `return` instructions in the `isIdenticalToWhenDefined` case seems wrong, since it means that instructions that are identical but fail this check are treated more pessimistically than instructions that are not identical.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129370/new/

https://reviews.llvm.org/D129370