[PATCH] D146352: Introduce `llvm-min-tblgen` to build public header files

[NAKAMURA Takumi via Phabricator via llvm-commits]

chapuni marked an inline comment as done.
chapuni added inline comments.


================
Comment at: llvm/cmake/modules/TableGen.cmake:185
+      add_custom_target(${target}-host DEPENDS ${${project}_TABLEGEN_EXE})
+      set(${project}_TABLEGEN_TARGET ${target}-host PARENT_SCOPE)
 
----------------
mstorsjo wrote:
> chapuni wrote:
> > mstorsjo wrote:
> > > I guess these two lines could be consider a standalone NFC refactoring/cleanup on top of the current code as well?
> > It is leftover in my attempts.
> > Would it be better to rewind it? I prefer this.
> I think the refactoring is good, but I think you could split it out from this patch and apply it directly (or send a separate patch which should be quick and easy to review+approve), and rebase this on top of it.
Okay, I've split it to D149343.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146352/new/

https://reviews.llvm.org/D146352