[PATCH] D149267: [AArch64][SVE] Add basic predicated add/sub patterns

[Paul Walker via Phabricator via llvm-commits]

paulwalker-arm added a comment.

I'm tempted to suggest this is better done as a canonicalisation via DAGCombine? Otherwise we then have to start duplicating other instances of these patterns, for example within mla/mls patfrags.

With `(add node:$op1, (vselect node:$pred, node:$op2, (SVEDup0)))` having one less use of `op1` than `(vselect node:$pred, (add node:$op1, node:$op2), node:$op1)`, such a canonicalisation might have other benefits where combines/patterns are guarded by `hasOneUse()`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149267/new/

https://reviews.llvm.org/D149267