[PATCH] D149327: [llvm-exegesis] Create snippet object files with predictable names

Pavel Kosov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 27 02:12:43 PDT 2023


kpdev42 created this revision.
kpdev42 added reviewers: courbet, tstellar.
kpdev42 added a project: LLVM.
Herald added subscribers: mstojanovic, ormris, atanasyan, jrtc27, sdardis.
Herald added a project: All.
kpdev42 requested review of this revision.

To make it possible to dump multiple objects during a single run, the
output files are named `/path/to/snippet-OPCODE-REPETITOR.o` with constant
parts omitted (for example, if dumping a single object file, its name is
exactly the value of `--dump-object-to-disk` option).

In dbc76ef791 <https://reviews.llvm.org/rGdbc76ef7915f925970f7bae1c5b79f3dcf55d85e>, the call to `writeObjectFile()` function was moved to
`runConfiguration()` because the latter is inherently serial to make the
"Check generated assembly with: ..." lines readable. Because now file
names are predictable, this message is not needed anymore, so the
`writeObjectFile()` function can be called at any suitable place.

~~

Huawei RRI, OS Lab


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D149327

Files:
  llvm/docs/CommandGuide/llvm-exegesis.rst
  llvm/test/tools/llvm-exegesis/X86/latency/dump-object-to-disk.s
  llvm/test/tools/llvm-exegesis/X86/uops/uops-HLT.s
  llvm/tools/llvm-exegesis/lib/BenchmarkResult.h
  llvm/tools/llvm-exegesis/lib/BenchmarkRunner.cpp
  llvm/tools/llvm-exegesis/lib/BenchmarkRunner.h
  llvm/tools/llvm-exegesis/lib/CMakeLists.txt
  llvm/tools/llvm-exegesis/lib/FileNameGenerator.cpp
  llvm/tools/llvm-exegesis/lib/FileNameGenerator.h
  llvm/tools/llvm-exegesis/lib/SnippetGenerator.cpp
  llvm/tools/llvm-exegesis/lib/SnippetRepetitor.cpp
  llvm/tools/llvm-exegesis/lib/SnippetRepetitor.h
  llvm/tools/llvm-exegesis/llvm-exegesis.cpp
  llvm/unittests/tools/llvm-exegesis/Mips/BenchmarkResultTest.cpp
  llvm/unittests/tools/llvm-exegesis/X86/BenchmarkResultTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D149327.517490.patch
Type: text/x-patch
Size: 29323 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230427/b7e545a7/attachment.bin>


More information about the llvm-commits mailing list