[PATCH] D148980: [X86] Machine combine vnni instruction.

[Phoebe Wang via Phabricator via llvm-commits]

pengfei accepted this revision.
pengfei added a comment.
This revision is now accepted and ready to land.

LGTM with some nits.



================
Comment at: llvm/lib/Target/X86/X86InstrInfo.cpp:9797-9800
+    // vpdpwssd xmm2,xmm3,XMMWORD PTR [r8+0x20]
+    // -->
+    // vpmaddwd xmm3,xmm3,XMMWORD PTR [r8+0x20]
+    // vpaddd xmm2,xmm2,xmm3
----------------
indent.

I think we don't need to duplicate for ymm and zmm. And maybe better to choose rr version as example.


================
Comment at: llvm/lib/Target/X86/X86InstrInfo.cpp:9851
+  // Create vpmaddwd.
+  auto *RC = RegInfo.getRegClass(Root.getOperand(0).getReg());
+  Register NewReg = RegInfo.createVirtualRegister(RC);
----------------
Avoid `auto`


================
Comment at: llvm/lib/Target/X86/X86InstrInfo.h:605
 
+  bool
+  getMachineCombinerPatterns(MachineInstr &Root,
----------------
Nit: Should copy+paste the comment here like others.


================
Comment at: llvm/lib/Target/X86/X86InstrInfo.h:610
+
+  void genAlternativeCodeSequence(
+      MachineInstr &Root, MachineCombinerPattern Pattern,
----------------
ditto.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148980/new/

https://reviews.llvm.org/D148980