[PATCH] D144306: [BOLT] adding hash computation for basic blocks

[Amir Ayupov via Phabricator via llvm-commits]

Amir added inline comments.


================
Comment at: bolt/include/bolt/Profile/ProfileYAMLMapping.h:129
     YamlIO.mapRequired("insns", BBP.NumInstructions);
+    YamlIO.mapRequired("hash", BBP.Hash);
     YamlIO.mapOptional("exec", BBP.ExecCount, (uint64_t)0);
----------------
Does it have to be a required field? This change breaks internal tests utilizing yaml profile which obviously don't have this field. I tried using an Optional instead and everything worked.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144306/new/

https://reviews.llvm.org/D144306