[PATCH] D149252: [hwasan] fix false positive when hwasan-match-all-tag flag is enabled and short granules are used

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 26 19:26:41 PDT 2023


vitalybuka added inline comments.


================
Comment at: compiler-rt/test/hwasan/TestCases/short-granule-and-match-all-tag.cpp:1-18
+// RUN: %clang_hwasan -mllvm -hwasan-match-all-tag=0 %s -o %t && %run %t 2>&1 | FileCheck %s
+
+#include <sanitizer/hwasan_interface.h>
+#include <stdio.h>
+#include <stdlib.h>
+
+int main() {
----------------
exit 0 is enough for this test


================
Comment at: llvm/test/CodeGen/AArch64/hwasan-check-memaccess.ll:115
 ; CHECK-NEXT: b __hwasan_tag_mismatch
+
+; CHECK:      __hwasan_check_x1_16777232_short_v2:
----------------
can you please precommit this test with the current state of HWASAN, so we can see a difference here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149252/new/

https://reviews.llvm.org/D149252



More information about the llvm-commits mailing list