[PATCH] D149221: [NFC][HWASAN] Move getUARTag into the Entry

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis accepted this revision.
eugenis added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:1053
 Value *HWAddressSanitizer::getStackBaseTag(IRBuilder<> &IRB) {
   if (ClGenerateTagsWithCalls)
+    return nullptr;
----------------
kstoimenov wrote:
> Should we make this into an assert? 
nullptr is fine because we do not need the base tag when ClGenerateTagsWithCalls.

We could turn it into Optional<> but I do not see the point.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149221/new/

https://reviews.llvm.org/D149221