[PATCH] D148877: [PGO]Implement metadata combine for 'branch_weights' of direct callsites when none of the instructions folds the rest away

Mingming Liu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 26 14:36:05 PDT 2023


mingmingl updated this revision to Diff 517320.
mingmingl marked 3 inline comments as done.
mingmingl retitled this revision from "[PGO]Implement metadata combine for 'branch_weights' of direct callsites" to "[PGO]Implement metadata combine for 'branch_weights' of direct callsites when none of the instructions folds the rest away".
mingmingl edited the summary of this revision.
mingmingl added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: hoy.

gate the sum of branch weights by `DoesKMove` and add test case when one callsite folds away (GVN'ed the other)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148877/new/

https://reviews.llvm.org/D148877

Files:
  llvm/include/llvm/IR/Metadata.h
  llvm/lib/IR/Metadata.cpp
  llvm/lib/Transforms/Utils/Local.cpp
  llvm/test/Transforms/GVN/calls-readonly.ll
  llvm/test/Transforms/SimplifyCFG/merge-direct-call-branch-weights-in-hoist.ll
  llvm/test/Transforms/SimplifyCFG/merge-direct-call-branch-weights-in-sink.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D148877.517320.patch
Type: text/x-patch
Size: 12254 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230426/6839a071/attachment.bin>


More information about the llvm-commits mailing list