[PATCH] D148841: [LV] Use SCEV for uniformity analysis across VF

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/lib/Analysis/LoopAccessAnalysis.cpp:2600-2602
+    return SE.getUDivExpr(
+        SCEVRewriteVisitor<SCEVAddRecRewriter>::visit(S->getOperand(0)),
+        SCEVRewriteVisitor<SCEVAddRecRewriter>::visit(S->getOperand(1)));
----------------
Maybe?


================
Comment at: llvm/lib/Analysis/LoopAccessAnalysis.cpp:2663
+          IthLaneRewriter.canAnalyze() &&
+          SE->isKnownPredicate(CmpInst::ICMP_EQ, FirstLaneExpr, IthLaneExpr) &&
+          "first and last lane are equal, but not all lanes in between");
----------------
In line with the other comparison?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148841/new/

https://reviews.llvm.org/D148841