[PATCH] D149256: [IR][NFC] Change UndefMaskElem to PoisonMaskElem

[Nikita Popov via Phabricator via llvm-commits]

nikic requested changes to this revision.
nikic added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/include/llvm-c/Core.h:4097
+ * \Returns the result of \c LLVMGetUndefMaskElem() if the mask value is
+ * undefined at that position.
  */
----------------
undefined -> poison?


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:964
   for (int I = 0, E = SubMask.size(); I < E; ++I) {
-    if ((!ExtendingManyInputs &&
-         (SubMask[I] >= TermValue || Mask[SubMask[I]] >= TermValue)) ||
-        SubMask[I] == UndefMaskElem)
+    if (SubMask[I] >= TermValue || SubMask[I] == PoisonMaskElem ||
+        Mask[SubMask[I]] >= TermValue)
----------------
Why did the ExtendingManyInputs checks go away here?


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:6350
+  return Cost;
+}
+
----------------
Rebase mistake?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149256/new/

https://reviews.llvm.org/D149256