[PATCH] D149112: InstCombine: Try to turn is.fpclass sign checks to fcmp with 0

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp:848-851
+  case fcPosSubnormal | fcPosNormal | fcPosInf:
+    if (inputDenormalIsIEEE(F, Ty))
+      return FCmpInst::FCMP_OGT;
+    break;
----------------
foad wrote:
> Any reason not to add the DAZ counterpart of this case, i.e. `fcPosNormal | fcPosInf`? And the same for OLT.
It is already handled, this is called twice. The second time with the inverted mask (so actually we have some redundant cases here). I could either expand all the cases here and stop doing the invert trick, or trim the redundant cases 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149112/new/

https://reviews.llvm.org/D149112