[PATCH] D146483: Add infrastructure to use EmitC-generated models for inlining.

[Marius Brehler via Phabricator via llvm-commits]

marbre added inline comments.


================
Comment at: llvm/include/llvm/Analysis/EmitCTensor.h:1
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
----------------
mtrofin wrote:
> won't this be part of the model package, i.e. something that's (maybe cloned) per-model?
I actually had the same question in mind and I am not sure if `llvm/include/llvm/Analysis` is a good location for this. However, we discussed some time ago if we should upstream the whole reference implementation, see https://discourse.llvm.org/t/tosa-reference-model-from-mlir-using-emitc/4799/11.

Furthermore, I don't know if it is acceptable to upstream code not licensed under `Apache-2.0 WITH LLVM exceptions`. The good news is, we would be able to re-license (most of) the reference implementation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146483/new/

https://reviews.llvm.org/D146483