[PATCH] D148254: [OpenMP][Flang][Semantics] Add semantics support for USE_DEVICE_PTR clause on OMP TARGET DATA directive.

Kiran Chandramohan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 26 06:10:10 PDT 2023


kiranchandramohan accepted this revision.
kiranchandramohan added a comment.
This revision is now accepted and ready to land.

LGTM. Thanks for the patch and for addressing the review comments.

In D148254#4297176 <https://reviews.llvm.org/D148254#4297176>, @raghavendhra wrote:

> In D148254#4290092 <https://reviews.llvm.org/D148254#4290092>, @kiranchandramohan wrote:
>
>> Also include the reason.
>
> Can you please point me to the location where I should be adding the reason. Should it be mentioned in  If so under which section should I mention it.

Yes, in `flang/docs/OpenMP-semantics.md`. Please add as additional info in the sections where you made changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148254/new/

https://reviews.llvm.org/D148254



More information about the llvm-commits mailing list