[PATCH] D146491: workflows/release-tasks: Upload lit releases to pypi

[Konrad Wilhelm Kleine via Phabricator via llvm-commits]

kwk requested changes to this revision.
kwk added a comment.
This revision now requires changes to proceed.

Looks much better now. Thank you for applying my suggestions @tstellar ! As usual I hope the github action runs and is valid YAML. There's just one more thing where I need confirmation on: Have you tried running the `Upload lit TestPyPI` step? I've done releases to pypi and test.pypi in the recent past and I'm nearly 100% sure that you need a second API token for this.  Here you're using `LLVM_LIT_PYPI_API_TOKEN` both, for the `Upload lit TestPyPI` step as well as the `Upload lit`.



================
Comment at: .github/workflows/release-tasks.yml:101
+
+      - name: Upload lit TestPyPI
+        uses: pypa/gh-action-pypi-publish at release/v1
----------------



================
Comment at: .github/workflows/release-tasks.yml:104
+        with:
+          password: ${{ secrets.LLVM_LIT_PYPI_API_TOKEN }}
+          repository-url: https://test.pypi.org/legacy/
----------------
I'm pretty sure you need need a different token for this than for the final upload to pypi. Try to log in to test.pypi.org and see for yourself.


================
Comment at: .github/workflows/release-tasks.yml:107
+
+      - name: Upload lit
+        uses: pypa/gh-action-pypi-publish at release/v1
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146491/new/

https://reviews.llvm.org/D146491