[PATCH] D149235: Always emit symbol table when dwarf section exists in COFF

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

> This also fixes check prefix NO which never worked in symtab.test

I disagree with this statement; the check worked (otherwise we would have seen test failures?), but I agree that the test was pointless before the fix in this patch.



================
Comment at: lld/test/COFF/symtab.test:151
+    SectionData:     0000
+  - Name:            .debug_info
+    Characteristics: [ IMAGE_SCN_CNT_INITIALIZED_DATA, IMAGE_SCN_MEM_DISCARDABLE, IMAGE_SCN_MEM_READ ]
----------------
Shouldn't we leave out the `.debug_info` section? Otherwise it kinda makes the existing tests, that test `/debug:symtab` and `/debug:dwarf`, kinda not actually test the options themselves?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149235/new/

https://reviews.llvm.org/D149235