[PATCH] D149252: [hwasan] fix false positive when hwasan-match-all-tag flag is enabled and short granules are used

Mingjie Xu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 26 05:36:20 PDT 2023


Enna1 created this revision.
Herald added a subscriber: hiraditya.
Herald added a project: All.
Enna1 updated this revision to Diff 517131.
Enna1 added a comment.
Enna1 edited the summary of this revision.
Enna1 added reviewers: vitalybuka, eugenis, pcc.
Enna1 added a subscriber: MTC.
Enna1 updated this revision to Diff 517133.
Enna1 published this revision for review.
Herald added projects: Sanitizers, LLVM.
Herald added subscribers: llvm-commits, Sanitizers.

update


Enna1 added a comment.

update


When hwasan-match-all-tag flag is enabled and short granules are used, at the point checking if this is a short tag case, the tag from pointer is stored in X16 register, 
which breaks the assumption that tag from shadow memory is stored in X16 register, this will cause a false positive.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D149252

Files:
  compiler-rt/test/hwasan/TestCases/short-granule-and-match-all-tag.cpp
  llvm/lib/Target/AArch64/AArch64AsmPrinter.cpp
  llvm/test/CodeGen/AArch64/hwasan-check-memaccess.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D149252.517133.patch
Type: text/x-patch
Size: 3737 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230426/528b3f8a/attachment-0001.bin>


More information about the llvm-commits mailing list