[llvm] 52b51ee - [RISCV][NFC] Remove outdated TODOs about extension versions in RISCVISAInfo

Alex Bradbury via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 26 01:59:40 PDT 2023


Author: Alex Bradbury
Date: 2023-04-26T09:58:57+01:00
New Revision: 52b51ee0d422b4073710eb5aa6cd59c315fb327d

URL: https://github.com/llvm/llvm-project/commit/52b51ee0d422b4073710eb5aa6cd59c315fb327d
DIFF: https://github.com/llvm/llvm-project/commit/52b51ee0d422b4073710eb5aa6cd59c315fb327d.diff

LOG: [RISCV][NFC] Remove outdated TODOs about extension versions in RISCVISAInfo

As was documented in D147183, we don't currently intend to support
multiple versions of specifications simultaneously. While external
circumstances might mean exceptions to this are needed, the TODOs about
reflecting version numbers in the feature strings no longer make sense.

Added: 
    

Modified: 
    llvm/lib/Support/RISCVISAInfo.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Support/RISCVISAInfo.cpp b/llvm/lib/Support/RISCVISAInfo.cpp
index 40cb45c7dd126..42fc2d3222143 100644
--- a/llvm/lib/Support/RISCVISAInfo.cpp
+++ b/llvm/lib/Support/RISCVISAInfo.cpp
@@ -687,8 +687,6 @@ RISCVISAInfo::parseArchString(StringRef Arch, bool EnableExperimentalExtension,
   Exts = Exts.drop_front(ConsumeLength);
   Exts.consume_front("_");
 
-  // TODO: Use version number when setting target features
-
   auto StdExtsItr = StdExts.begin();
   auto StdExtsEnd = StdExts.end();
   auto GoToNextExt = [](StringRef::iterator &I, unsigned ConsumeLength) {
@@ -736,7 +734,6 @@ RISCVISAInfo::parseArchString(StringRef Arch, bool EnableExperimentalExtension,
     }
 
     // The order is OK, then push it into features.
-    // TODO: Use version number when setting target features
     // Currently LLVM supports only "mafdcvh".
     if (!isSupportedExtension(StringRef(&C, 1))) {
       if (IgnoreUnknown) {


        


More information about the llvm-commits mailing list