[PATCH] D143162: [AArch64] Add PredictableSelectIsExpensive feature for the Neoverse V1

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 26 01:26:18 PDT 2023


SjoerdMeijer added a comment.

In D143162#4294917 <https://reviews.llvm.org/D143162#4294917>, @dmgreen wrote:

> I'm not a huge fan of this being neoverse-v1 only, I'm afraid. I don't know of any reason why it would be. I think we should follow the comment in https://reviews.llvm.org/D143162#4212859 and make the same change for all similar cpus.

Make sense. I don't want to hold up this patch. So I am okay to just add it for v2 too then. 
Then I will try to benchmark this later. I don't have time this week, maybe towards the end of next.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143162/new/

https://reviews.llvm.org/D143162



More information about the llvm-commits mailing list