[PATCH] D148347: [AArch64] Handle vector with two different values

[JinGu Kang via Phabricator via llvm-commits]

jaykang10 added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:12241
+  unsigned ConsecutiveValCount = 0;
+  SmallVector<int, 16> MaskVec;
+  SDValue PrevVal;
----------------
efriedma wrote:
> The name "MaskVec" is a bit confusing in this context...
> 
> Maybe it would be easier to understand if you just construct it later, in the `if (DifferentValueMap.size() == 2 && NumUndefLanes == 0)` codepath?
> The name "MaskVec" is a bit confusing in this context...
> 
> Maybe it would be easier to understand if you just construct it later, in the `if (DifferentValueMap.size() == 2 && NumUndefLanes == 0)` codepath?

Sorry for confusing.
Let me add more comments and update the code.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148347/new/

https://reviews.llvm.org/D148347