[PATCH] D139859: [symbolizer] Support symbol+offset lookup

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

In your patch description, please note the tool name is `llvm-symbolizer`, not `llvm-symbolize`. Please update accordingly.

Does GNU addr2line support just using a symbol without the offset? If so, I think it would be good to split the offset lookup functionality into a follow-on patch. It helps reduce the surface area of this patch into more digestible pieces for review and testing.



================
Comment at: llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp:209
+  // symbol with optional displacement.
+  StringRef Offset = StringRef(Pos).trim();
   // GNU addr2line assumes the offset is hexadecimal and allows a redundant
----------------
Why has this changed?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139859/new/

https://reviews.llvm.org/D139859