[PATCH] D148929: [mlir][test][Integration] Refactor Arm emulator configuration

Andrzej Warzynski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 26 00:27:34 PDT 2023


awarzynski accepted this revision.
awarzynski added a comment.
This revision is now accepted and ready to land.

LGTM, this is a massive improvement, thanks!



================
Comment at: mlir/test/Integration/lit.local.cfg:38-42
+# These two substitutions are equivalent but '%lli_aarch64_cmd' should
+# be used for integration tests that run exclusively on AArch64
+# (ArmSVE, ArmSME), and '%lli_host_or_aarch64_cmd' should be used for
+# tests that may run on the host OR AArch64, such as the SparseTensor
+# tests which have target-specific (SVE) and target-agnostic codepaths.
----------------
[nit] I think that splitting this into bullet points will improve readability (that's the only change that I am suggesting) 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148929/new/

https://reviews.llvm.org/D148929



More information about the llvm-commits mailing list