[PATCH] D149087: [lld] Allow input files from compatible architectures on EC targets.
Martin Storsjö via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 26 00:22:56 PDT 2023
mstorsjo accepted this revision.
mstorsjo added a comment.
This revision is now accepted and ready to land.
I think this looks reasonable
================
Comment at: lld/COFF/SymbolTable.cpp:42
+ case ARM64:
+ return mt == ARM64 || mt == ARM64X;
+ case ARM64EC:
----------------
Just to check that I've understood correctly here... We don't really expect the input of an individual object file to ever be `ARM64X`, but only `ARM64`, `AMD64` or `ARM64EC`, while `ARM64X` is an image level flag to indicate that it contains both `ARM64` and (`ARM64EC` or `AMD64`), more or less?
(I don't mind keeping the case here just for completeness anyway though.)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149087/new/
https://reviews.llvm.org/D149087
More information about the llvm-commits
mailing list