[PATCH] D149198: [DAGCombiner] Make is so that `udiv` can be folded with `(select c, NonZero, 1)`

Wed Apr 26 00:02:15 PDT 2023

pengfei added a comment.

In D149198#4297846 <https://reviews.llvm.org/D149198#4297846>, @craig.topper wrote:

> In D149198#4297802 <https://reviews.llvm.org/D149198#4297802>, @goldstein.w.n wrote:
>
>> Did general refactror.
>
> Does that increase the review burden? Now we have to audit the other transforms to make sure the don't change operand 1 in a way that would be unsafe?
>
> Plus we should have additional tests?

Maybe we can use another NFC patch to refactor the interface only?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149198/new/

https://reviews.llvm.org/D149198