[PATCH] D148876: [IndirectCallPromotion] Clear value profile metadata after the last run of indirect-call-promotion in a pipeline

Tue Apr 25 23:03:13 PDT 2023

wenlei added a comment.

In D148876#4288504 <https://reviews.llvm.org/D148876#4288504>, @mingmingl wrote:

> In D148876#4288286 <https://reviews.llvm.org/D148876#4288286>, @tejohnson wrote:
>
>> Would be good to explain motivation (maybe reference other patch?)
>
> Makes sense, will do.

Can I piggyback on this to suggest a general feedback :) Reviewers would benefit from more explanation on why, in addition to what, and it applies to other patches as well. Without asking explicitly, I failed to grasp your intention of D147954 <https://reviews.llvm.org/D147954> just by looking at the patch without asking questions. It somewhat applies to the profile reader changes too.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148876/new/

https://reviews.llvm.org/D148876