[PATCH] D149032: [InlineAsm][AArch64]Add backend support for flag output parameters
Mingming Liu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 25 22:58:48 PDT 2023
mingmingl added a comment.
In D149032#4297534 <https://reviews.llvm.org/D149032#4297534>, @efriedma wrote:
> clang shouldn't abort by default, as far as I know?
You are correct. After relaxing the assert condition in GlobalISel/InlineAsmLowering.cpp, the crashing `O0` command generates valid output, indicating the abort option is not on -> after digging a little bit, the aarch64 target machine turns abort off <https://github.com/llvm/llvm-project/blob/1e4de2d2701633a97de96c7a55353879ec9b7aa4/llvm/lib/Target/AArch64/AArch64TargetMachine.cpp#L365>. So no change needed in 'clang/lib/Driver/ToolChains/Clang.cpp'.
> Anyway, this patch looks fine.
Thanks for reviews!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149032/new/
https://reviews.llvm.org/D149032
More information about the llvm-commits
mailing list