[PATCH] D149132: [LICM] Reassociate & hoist add expressions

[Max Kazantsev via Phabricator via llvm-commits]

mkazantsev added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LICM.cpp:2588
+  // flag on operation, and the no-overflow of the new RHS is checked below.
+  if (!cast<OverflowingBinaryOperator>(LHS)->hasNoSignedWrap())
+    return false;
----------------
skatkov wrote:
> Will SCEV more powerful to check that LHS is NSW then just check of flag on instruction?
In theory, yes.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149132/new/

https://reviews.llvm.org/D149132