[PATCH] D133863: [RISCV] Add MC support of RISCV zcmt Extension
Craig Topper via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 25 21:10:26 PDT 2023
craig.topper requested changes to this revision.
craig.topper added inline comments.
This revision now requires changes to proceed.
================
Comment at: llvm/lib/Support/RISCVISAInfo.cpp:853
Error RISCVISAInfo::checkDependency() {
+ bool HasC = Exts.count("c") != 0;
bool HasD = Exts.count("d") != 0;
----------------
This variable is unused.
================
Comment at: llvm/lib/Support/RISCVISAInfo.cpp:913
+ if (HasZcmt && (HasD || HasZcd))
+ return createStringError(
----------------
It wouldn't be incompatible with Zca + D without Zcd would it?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133863/new/
https://reviews.llvm.org/D133863
More information about the llvm-commits
mailing list