[PATCH] D147545: [AutoFDO] Stale profile matching(part 2)

Wenlei He via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 25 21:02:04 PDT 2023


wenlei added a comment.

In D147545#4287782 <https://reviews.llvm.org/D147545#4287782>, @hoy wrote:

> How about retitle it as "[AutoFDO] Stale profile matching (part 2)" to align with the first patch? It's mentioned in the summary that only supports CSSPGO for now, so it should be good.

I found this confusing, and the patch really isn't about AutoFDO, but CSSPGO. Maybe rename the first patch as [CSSPGO] instead for consistency. Or just say SamplePGO to avoid differentiating the two.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147545/new/

https://reviews.llvm.org/D147545



More information about the llvm-commits mailing list