[PATCH] D149130: [PartialInlining] Fix incorrect costing when IR has unreachable BBs

[Vedant Paranjape via Phabricator via llvm-commits]

vedant-amd added a comment.

In D149130#4296535 <https://reviews.llvm.org/D149130#4296535>, @fhahn wrote:

> If the block is unreachable, how come it is even considered for outlining?

I think there's simply no check in place, https://github.com/llvm/llvm-project/blob/8fc1764ef3d18b65b52f82ca4a6bf56ac024e589/llvm/lib/Transforms/IPO/PartialInlining.cpp#L1182

It just checks if the BB can be inlined, if not it marks it for outlining.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149130/new/

https://reviews.llvm.org/D149130