[PATCH] D145872: TableGen: Let expressions available to list subscripts and list slices

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/docs/TableGen/ProgRef.rst:527
 
+    *value*\ ``[i,m...n,j,ls]``
+        Each element may be an expression (variables, bang operators).
----------------
chapuni wrote:
> arsenm wrote:
> > This section is indented further than the others 
> It is intentional that this is the subitem as supplement, since I wanted to avoid rewriting whole this item.
> Could I rewrote this flat? Or I am happy if you could suggest an alternative sentense.
I'm not sure, I have a hard time judging what the rendered output of this will look like 


================
Comment at: llvm/lib/TableGen/Record.cpp:1205
+        auto i = II->getValue();
+        if (!(0 <= i && i < (ssize_t)TheList->size()))
+          goto listslice_fail;
----------------
demorgan the condition 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145872/new/

https://reviews.llvm.org/D145872