[PATCH] D149212: [MCParser] Add warning for zero-size .fill

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 25 16:12:04 PDT 2023


arsenm added inline comments.


================
Comment at: llvm/lib/MC/MCParser/AsmParser.cpp:3357-3364
+  if (FillSize == 0) {
+    Warning(SizeLoc, "'.fill' directive with 0 size has no effect");
+    return false;
+  }
   if (FillSize < 0) {
     Warning(SizeLoc, "'.fill' directive with negative size has no effect");
     return false;
----------------
Could you just have one message with the value instead 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149212/new/

https://reviews.llvm.org/D149212



More information about the llvm-commits mailing list