[PATCH] D149196: [SelectionDAG] Use `computeKnownBits` if `Op` is not recognized by `isKnownNeverZero`

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:5020
 
-  return false;
+  return !computeKnownBits(Op, Depth).One.isZero();
 }
----------------
I think you want Depth -1 here to counteract the increment earlier. The switch in computeKnownBits should be the same depth as the switch in this function.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149196/new/

https://reviews.llvm.org/D149196