[PATCH] D149200: [X86][WIP] Enable `foldSelectWithIdentityConstant` for scalar types.

[Noah Goldstein via Phabricator via llvm-commits]

goldstein.w.n created this revision.
goldstein.w.n added reviewers: pengfei, RKSimon, nikic.
Herald added subscribers: StephenFan, ecnelises, hiraditya.
Herald added a project: All.
goldstein.w.n requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

There are a variety of regressions at the moment, but it would be nice
if we could turn this on in the backend effectively so that
`InstCombine` can generically fold `(select c, BinOp(X, Y), X)` ->
`BinOp(X, (select c, Y, Indentity))` which is generally preferable in
the middle-end.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D149200

Files:
  llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
  llvm/lib/Target/X86/X86ISelLowering.cpp
  llvm/test/CodeGen/X86/add-cmov.ll
  llvm/test/CodeGen/X86/avx512-intrinsics-fast-isel.ll
  llvm/test/CodeGen/X86/avx512-select.ll
  llvm/test/CodeGen/X86/bitcast-and-setcc-256.ll
  llvm/test/CodeGen/X86/bool-simplify.ll
  llvm/test/CodeGen/X86/bool-vector.ll
  llvm/test/CodeGen/X86/fildll.ll
  llvm/test/CodeGen/X86/fold-select.ll
  llvm/test/CodeGen/X86/fp-cvt.ll
  llvm/test/CodeGen/X86/fp-intrinsics.ll
  llvm/test/CodeGen/X86/fp-strict-scalar-inttofp.ll
  llvm/test/CodeGen/X86/fp128-i128.ll
  llvm/test/CodeGen/X86/fp80-strict-scalar.ll
  llvm/test/CodeGen/X86/fptoui-sat-scalar.ll
  llvm/test/CodeGen/X86/half.ll
  llvm/test/CodeGen/X86/jump_sign.ll
  llvm/test/CodeGen/X86/lea-opt2.ll
  llvm/test/CodeGen/X86/machine-trace-metrics-crash.ll
  llvm/test/CodeGen/X86/midpoint-int.ll
  llvm/test/CodeGen/X86/pic.ll
  llvm/test/CodeGen/X86/pr15309.ll
  llvm/test/CodeGen/X86/pr22338.ll
  llvm/test/CodeGen/X86/pr44396.ll
  llvm/test/CodeGen/X86/pr47482.ll
  llvm/test/CodeGen/X86/scalar-fp-to-i64.ll
  llvm/test/CodeGen/X86/scalar-int-to-fp.ll
  llvm/test/CodeGen/X86/select-of-fp-constants.ll
  llvm/test/CodeGen/X86/select.ll
  llvm/test/CodeGen/X86/select_const.ll
  llvm/test/CodeGen/X86/setcc-combine.ll
  llvm/test/CodeGen/X86/uint64-to-float.ll
  llvm/test/CodeGen/X86/use-cr-result-of-dom-icmp-st.ll
  llvm/test/CodeGen/X86/vec-strict-inttofp-128.ll
  llvm/test/CodeGen/X86/vec-strict-inttofp-256.ll
  llvm/test/CodeGen/X86/vec-strict-inttofp-512.ll
  llvm/test/CodeGen/X86/vselect-zero.ll
  llvm/test/CodeGen/X86/zext-sext.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D149200.516916.patch
Type: text/x-patch
Size: 216492 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230425/dc02e242/attachment-0001.bin>