[PATCH] D149086: [lld] Use correct machine type in ARM64EC COFF headers.

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added inline comments.


================
Comment at: lld/test/COFF/arm64ec.test:11
+ARM64EC-HEADER-NEXT: AddressSize: 64bit
+ARM64EC-HEADER:      Machine: IMAGE_FILE_MACHINE_AMD64 (0x8664)
+
----------------
Is it possible to add a check for `arm64x` too, or is harder to create such object files?


================
Comment at: lld/test/COFF/arm64ec.test:14
+RUN: llvm-readobj --hex-dump=.data test.dll | FileCheck -check-prefix=DATAEC %s
+DATAEC: 02020202
+
----------------
It’sa bit unclear what the `DATAEC` check here really verifies? I’m sure it’s relevant later on, but within the scope of this patch, this test feels mostly confusing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149086/new/

https://reviews.llvm.org/D149086