[PATCH] D149124: [llvm-profdata] ProfileReader cleanup - preparation for MD5 refactoring - 3

William Junda Huang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 25 12:18:57 PDT 2023


huangjd marked an inline comment as done.
huangjd added inline comments.


================
Comment at: llvm/include/llvm/ProfileData/SampleProfReader.h:689
+  /// to determine a cutoff.
+  bool useOrderedFuncOffsets() {
+    return ProfileIsCS || (!useMD5() && Remapper);
----------------
davidxl wrote:
> does it need to check the section flag?
I added back the section flag to check if CS profile has ordered function offset table.  


================
Comment at: llvm/include/llvm/ProfileData/SampleProfReader.h:808
 
   bool FuncOffsetsOrdered = false;
 
----------------
davidxl wrote:
> Is this a dead field?
Updated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149124/new/

https://reviews.llvm.org/D149124



More information about the llvm-commits mailing list