[PATCH] D147544: [BOLT] Move from RuntimeDyld to JITLink

Tue Apr 25 09:59:13 PDT 2023

Amir added a comment.

In D147544#4295564 <https://reviews.llvm.org/D147544#4295564>, @jobnoorman wrote:

> In D147544#4295243 <https://reviews.llvm.org/D147544#4295243>, @jobnoorman wrote:
>
>> In D147544#4294205 <https://reviews.llvm.org/D147544#4294205>, @rafauler wrote:
>>
>>> We have one MachO test failing. this is currently not available on llvm repo, I posted a diff with them:
>>
>> I think this is a bug in BOLT on `main`. See my comments in D149113 <https://reviews.llvm.org/D149113>. I'll try to figure out what's going on there.
>
> The problem is that on `main`, `MachORewriteInstance::emitAndLink` never calls `RuntimeDyld::finalizeWithMemoryManagerLocking` so relocations are never processed. The following patch fixes this and with it, BOLT on `main` produces the same (correct) output as with the `JITLink` patch. I'm not sure if it's worth it to post this patch for review.
>
> F27239022: macho.patch <https://reviews.llvm.org/F27239022>

This fix should also be incorporated, please submit it as a separate diff.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147544/new/

https://reviews.llvm.org/D147544