[PATCH] D149091: [Object] Recognize ARM64EC binaries in COFFObjectFile::getMachine.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 25 09:42:23 PDT 2023


efriedma added a comment.

> I guess we could have some helper syntax for that in yaml2obj, but it's not clear to me how it should look like.

Someone can always use llvm-readobj or dumpbin to help understand the fine details if necessary, so it's not a big deal if it's only a few tests (particularly if they have comments explaining the tricky bits).

We could invent a new kind of "SectionData" that allows structured data, instead of just a string, I guess.  We don't want to get too fancy here; even just representing the string as an array of 32-bit integers would be sufficient to annotate various bits using comments.

Adding a mechanism for relocations to represent RVAs seems overkill. yaml2obj is intentionally kept simple.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149091/new/

https://reviews.llvm.org/D149091



More information about the llvm-commits mailing list