[PATCH] D149162: [Clang][OpenMP][IRBuilder] Move registerTargetGlobalVariable & getAddrOfDeclareTargetVar into the OMPIRBuilder
Andrew Gozillon via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 25 08:16:56 PDT 2023
agozillon added a comment.
I've tested this with the two following combinations, x86/AMDGPU and x86/NVPTX (newer plugin I think, not old, a little unsure on the runtime segment) and it passes the Clang test suites, if there is anything else I can do to make sure this is tested nicely and due diligence has been done please do mention it!
I admit the lengthy argument list is probably not the prettiest in the world, but the other option I could think of was an interface class of some kind that Clang+Flang could fill, or implement but that feels more like additional boilerplate than a fix.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149162/new/
https://reviews.llvm.org/D149162
More information about the llvm-commits
mailing list