[PATCH] D147172: [OpenMP][Flang][MLIR] Add lowering of TargetOp for host codegen

[Jan Sjödin via Phabricator via llvm-commits]

jsjodin marked an inline comment as done.
jsjodin added inline comments.


================
Comment at: mlir/lib/Target/LLVMIR/CMakeLists.txt:42
   MLIRTranslateLib
+  MLIROpenMPDialect
   )
----------------
kiranchandramohan wrote:
> Nit: Please reconfirm that this is required.
It is needed, link error if not there.


================
Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:14
 #include "mlir/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.h"
+#include "mlir/Dialect/LLVMIR/LLVMOps.cpp.inc"
 #include "mlir/Dialect/OpenMP/OpenMPDialect.h"
----------------
kiranchandramohan wrote:
> Is this include required?
Not needed, will remove.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147172/new/

https://reviews.llvm.org/D147172