[PATCH] D149139: [AMDGPU] Do not handle _SGPR SMEM instructions in SILoadStoreOptimizer

[Jay Foad via Phabricator via llvm-commits]

foad added a comment.

> Another option might be to assert on the _SGPR cases, probably with a comment explaining the reason, rather than just removing them. The instructions still exist.

I plan to continue work on D147335 <https://reviews.llvm.org/D147335> which will remove the _SGPR Real instructions (on GFX10+). This will cause a hard failure if we accidentally select the _SGPR Pseudos, giving the same kind of assurance as the assertion you suggested.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149139/new/

https://reviews.llvm.org/D149139