[PATCH] D146974: [test] A test case for D146958

Tue Apr 25 07:03:24 PDT 2023

pawosm01 marked an inline comment as done.
pawosm01 added inline comments.

================
Comment at: llvm/test/Transforms/LoopVectorize/vector-no-scevcheck.ll:15
+  %mul0 = mul nsw i64 %i, %val2
+  %arrayidx0 = getelementptr inbounds double, ptr %0, i64 %mul0
+  %mul1 = mul nsw i64 %i, %val1
----------------
fhahn wrote:
> pawosm01 wrote:
> > fhahn wrote:
> > > Could you add a new function that's basically the same as `@foo` but has `%arrayidx0` in `%loop2.header`?
> > > Could you add a new function that's basically the same as @foo but has %arrayidx0 in %loop2.header?
> > 
> > This will not expose the same behavior of the D146958 patch we care about in this test (namely, `vector.scevcheck` will remain).
> > 
> Right, but that's only with the current version of the patch; it should be relatively straightforward to also handle this case (https://reviews.llvm.org/D146958#inline-1439048). In any case, it won't hurt to have negative test cases as well.
Hi Florian, your suggestion from the patch review has worked, hence I've modified this test file accordingly. I'd like to have your explicit approval before I merge this one.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146974/new/

https://reviews.llvm.org/D146974