[PATCH] D148728: [Support][Parallel] Add sequential mode to TaskGroup::spawn().
Andrew Ng via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 25 06:55:57 PDT 2023
andrewng accepted this revision.
andrewng added a comment.
This revision is now accepted and ready to land.
Apart from the comment nits, LGTM. Thanks!
================
Comment at: llvm/include/llvm/Support/Parallel.h:88
+ // Tasks marked with \p Sequential will be executed
+ // exactly in the order how they were spawned.
+ // Note: Sequential tasks may be done on the different
----------------
`how` -> `which`.
================
Comment at: llvm/include/llvm/Support/Parallel.h:89
+ // exactly in the order how they were spawned.
+ // Note: Sequential tasks may be done on the different
+ // threads, but strictly in sequential order.
----------------
`done` -> `executed` or `run`. Drop the `the`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148728/new/
https://reviews.llvm.org/D148728
More information about the llvm-commits
mailing list