[PATCH] D149146: [TailDuplicator] Don't constrain register classes due to debug instructions

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 25 05:06:31 PDT 2023


foad added inline comments.


================
Comment at: llvm/lib/CodeGen/TailDuplicator.cpp:434
+            // rather than constraining the register class further.
+            if (!NewMI.isDebugInstr())
+              ConstrRC = MRI->constrainRegClass(VI->second.Reg, OrigRC);
----------------
Just a cosmetic thing, I'd prefer you swap the "if" and "else" cases so you don't have an "else" after an already negated condition.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149146/new/

https://reviews.llvm.org/D149146



More information about the llvm-commits mailing list