[PATCH] D148631: ValueTracking: fdiv sign handling in computeKnownFPClass

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:4676
 
+    // X / -0.0 is -Inf (or NaN).
+    if (KnownLHS.isKnownNever(fcNegative) && KnownRHS.isKnownNever(fcNegative))
----------------
arsenm wrote:
> foad wrote:
> > Comment should say +ve / +ve is +ve.
> ve?
"+ve" is short for "positive". I just mean the comment should describe what the code is doing, instead of just mentioning a true but largely irrelevant fact.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148631/new/

https://reviews.llvm.org/D148631