[PATCH] D148549: ValueTracking: Implement computeKnownFPClass for log

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 25 04:20:29 PDT 2023


arsenm marked an inline comment as done.
arsenm added inline comments.


================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:4390
+        computeKnownFPClass(II->getArgOperand(0), DemandedElts,
+                            InterestedClasses, KnownSrc, Depth + 1, Q, TLI);
+
----------------
foad wrote:
> Blindly propagating InterestedClasses seems wrong again. E.g. if InterestedClasses contains fcNegInf then the value you pass down should contain fcZero.
It can't be incorrect, this can only improve precision. It's hard to get these right without relevant queries wired up


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148549/new/

https://reviews.llvm.org/D148549



More information about the llvm-commits mailing list