[PATCH] D148001: [LICM] Reassociate & hoist sub expressions
Serguei Katkov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 25 03:42:14 PDT 2023
skatkov added a comment.
General question: don't you want to separate sub and add handling in completely different functions.
To be honest, there will be small code duplication but in this case no need to mixup add and sub logic.
It will be easier to review and support in the future.
If duplication is a problem you can create functions for sub and add to keep first and last lines are in common.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148001/new/
https://reviews.llvm.org/D148001
More information about the llvm-commits
mailing list