[PATCH] D148631: ValueTracking: fdiv sign handling in computeKnownFPClass

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 25 02:41:12 PDT 2023


foad accepted this revision.
foad added a comment.
This revision is now accepted and ready to land.

LGTM with comment nit.



================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:4676
 
+    // X / -0.0 is -Inf (or NaN).
+    if (KnownLHS.isKnownNever(fcNegative) && KnownRHS.isKnownNever(fcNegative))
----------------
Comment should say +ve / +ve is +ve.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148631/new/

https://reviews.llvm.org/D148631



More information about the llvm-commits mailing list